This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat: listen to array of multiaddrs #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
ghost
assigned License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
docs: add some more jsdocs License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
dirkmc
suggested changes
Apr 20, 2019
There was a problem hiding this comment.
Thanks for putting together this PR @jacobheun ❤️
A couple of small things but otherwise looks good 👍
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
|
Merged into the async branch |
jacobheun
added a commit
that referenced
this pull request
Aug 19, 2019
* feat: support listen on array * chore: fix missing deps * chore: update interface version * docs: update readme for array listen * test: use port 0 * docs: add some more jsdocs * chore: fix travis support for ip6 on linux * refactor: clean up some code
jacobheun
pushed a commit
that referenced
this pull request
Aug 19, 2019
This reverts commit 5009c2c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to handle an array of multiaddrs on listen.
I also removed the ipfs id preservation. I'd like to get libp2p/js-libp2p#323 implemented as a part of the async/await transition.
Note: This is being PRd into the async/await branch and not master.
Travis Fix
I also added a fix for the IPv6 issue in Travis linux. resolves #105
This could probably be a separate PR, but I added it here to avoid the need to rebase this and #102