Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: array equals for non primitive types with equal function #8

Conversation

vasco-santos
Copy link
Member

Per discussion on libp2p/js-libp2p#681 (comment)

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 minor thing in the tests.

test/array-equals.spec.js Outdated Show resolved Hide resolved
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
@vasco-santos vasco-santos merged commit 2f81fc4 into master Jul 15, 2020
@vasco-santos vasco-santos deleted the feat/array-equals-for-non-primitive-types-with-equal-function branch July 15, 2020 10:28
D4nte referenced this pull request in D4nte/js-libp2p-utils Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants