Implement Connection #14
Conversation
| @@ -9,28 +9,35 @@ | |||
| "scripts": { | |||
| "build": "aegir build", | |||
| "clean": "rm -rfv node_modules dist *.lock *-lock.json ", | |||
| "test": "aegir test", | |||
| "test": "aegir test --target browser", | |||
There was a problem hiding this comment.
The example suggested targets for test, test:browser, and test:node.
But I suppose this project only targets a browser, right, so maybe we should only do that?
There was a problem hiding this comment.
Yes, this is because we don't intend to support node at the moment.
| timeline: { open: 0 }, | ||
| status: 'CLOSED', | ||
| direction: init.direction, | ||
| status: 'OPEN', |
There was a problem hiding this comment.
Is it always open immediately?
| this.peerConnection.createDataChannel(genUuid()); | ||
| throw new Error('not implemented'); | ||
| private wrapMsStream(rawStream: WebRTCStream, stream: Duplex<Uint8ArrayList, Uint8ArrayList | Uint8Array, Promise<void>>): ic.Stream { | ||
| return { |
There was a problem hiding this comment.
Is this wrapping just to be able to set the ID? Because if so... we could add that as an optional thing to StreamInit
| throw new Error('not implemented'); | ||
| let protocol = stream.stat.protocol!; | ||
| let direction = stream.stat.direction; | ||
| if (this.countStream(protocol, direction) === this.findStreamLimit(protocol, direction)) { |
There was a problem hiding this comment.
Although I understand it would be an incredibly bizarre implementation that did this, it seems to me to be at least possible that the data being fetched by findStreamLimit could theoretically change at runtime. So I'd be inclined to test with something like >=
| let metrics = this.components.getMetrics(); | ||
| let openError: Error | undefined; | ||
|
|
||
| log.trace(`opening new stream with protocols: ${protocols}`); |
There was a problem hiding this comment.
I see that we're not testing stream limits here. So those limits only apply to incoming streams, not the sum of the two?
| log('new outbound connection %s', rawConn, genUuid()); | ||
| throw new Error('not implemented'); | ||
| const rawConn = await this._connect(ma, options); | ||
| log(`dialing address - ${ma}`); |
There was a problem hiding this comment.
Given this happens after _connect, shouldn't it be "dialed" address?
|
|
||
| export const echoHandler: StreamHandler = ({ stream }) => pipe(stream.source, stream.sink); | ||
|
|
||
| export async function createConnectedRTCPeerConnectionPair(): Promise<RTCPeerConnection[]> { |
ddimaria
changed the title
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implement connection interface for RTCPeerConnection.