Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

refactor: remove use of timeout-abort-controller #148

Merged
merged 2 commits into from
May 3, 2023
Merged

refactor: remove use of timeout-abort-controller #148

merged 2 commits into from
May 3, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented May 1, 2023

@maschad maschad self-assigned this May 1, 2023
@maschad maschad requested a review from MarcoPolo May 1, 2023 19:01
@maschad maschad added the dependencies Pull requests that update a dependency file label May 1, 2023
@MarcoPolo
Copy link
Contributor

CI is failing though?

@maschad
Copy link
Member Author

maschad commented May 2, 2023

CI is failing though?

It's a bit strange that a lack of tests would cause an error and I am noticing it on other PRs looks like an issue with playwright

@MarcoPolo
Copy link
Contributor

yeah, I fixed it in #109

@MarcoPolo
Copy link
Contributor

let me merge that one, then you can merge master/rebase and get passing tests.

@maschad maschad merged commit 0a72552 into main May 3, 2023
@maschad maschad deleted the refactor/remove-use-timeout-abort branch May 3, 2023 02:56
@github-actions
Copy link

github-actions bot commented May 6, 2023

🎉 This PR is included in version 1.1.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees

@maschad maschad

Labels
dependencies Pull requests that update a dependency file released
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maschad @MarcoPolo