Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

WIP #2

Closed
wants to merge 5 commits into from
Closed

WIP #2

wants to merge 5 commits into from

Conversation

John-LittleBearLabs
Copy link
Contributor

@John-LittleBearLabs John-LittleBearLabs commented Aug 2, 2022

TODO

  • Skeletons for Transport, Connection, and Stream implementations
  • SDP munging
  • SDP creation
  • Implement Transport.dial
  • Implement remainder of Transport
  • Implement Connection.newStream
  • Implement remainder of Connection
  • Implement Stream.source
  • Implement Stream.sink
  • Implement remainder of Stream
  • Fill out README.md and any other worthwhile documentation
  • Unit test SDP utilities
  • Unit test Transport
  • Unit test Connection
  • Unit test Stream
  • Compliance testing
  • End-to-end test

.vscode/launch.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
src/stream.ts Show resolved Hide resolved
src/transport.ts Outdated Show resolved Hide resolved
src/transport.ts Outdated Show resolved Hide resolved
test/node.ts Outdated
@@ -0,0 +1,6 @@
/* eslint-env mocha */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider a different name for this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name seems to be the norm for aegir test, which I'm borrowing from *star.

If I just rename it without doing stuff to the package.json I get

Error: No test files found
Command failed with exit code 1: mocha test/node.{js,cjs,mjs} test/**/*.spec.{js,cjs,mjs} dist/test/node.{js,cjs,mjs} dist/test/**/*.spec.{js,cjs,mjs} --ui bdd --require source-map-support/register --timeout=60000 --bail
error Command failed with exit code 1.

I think I can make it work, though.

$./node_modules/.bin/mocha dist/test/notnode.js


  0 passing (2ms)

Do you have a preferred name? tests.ts ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there will only be a single file in this folder, maybe index.ts? If you'll mix unit and e2e, then unit.ts.

@John-LittleBearLabs
Copy link
Contributor Author

Moved to #4 during branch rename.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants