This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Build dist when installing from gh repository #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckousik
requested review from
John-LittleBearLabs,
ddimaria and
GlenDC
and removed request for
John-LittleBearLabs
|
@ckousik can you create an issue to remove this code once we merge into main? |
ddimaria
approved these changes
Nov 17, 2022
GlenDC
approved these changes
Nov 18, 2022
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to #58 , the repository does not get built when running
npm install little-bear-labs/js-libp2p-webrtc. A prepare script has been added to ensure that the dist folder is built. This is temporary and will be removed before moving this to libp2p.