chore: apply suggestions from code review

Co-authored-by: Jacob Heun <jacobheun@gmail.com>
libp2p · May 13, 2020 · 171af8a · 171af8a
1 parent 80e18c1
commit 171af8a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/doc/CONFIGURATION.md b/doc/CONFIGURATION.md
@@ -425,7 +425,7 @@ const node = await Libp2p.create({
 
 #### Setup with Keychain
 
-Libp2p allows you to setup a secure key chain to manage your keys. The keychain configuration object should have the following properties:
+Libp2p allows you to setup a secure keychain to manage your keys. The keychain configuration object should have the following properties:
 
 | Name | Type | Description |
 |------|------|-------------|

diff --git a/src/config.js b/src/config.js
@@ -1,6 +1,5 @@
 'use strict'
 
-const { MemoryDatastore } = require('interface-datastore')
 const mergeOptions = require('merge-options')
 const Constants = require('./constants')
 
@@ -18,9 +17,6 @@ const DefaultConfig = {
     maxDialsPerPeer: Constants.MAX_PER_PEER_DIALS,
     dialTimeout: Constants.DIAL_TIMEOUT
   },
-  keychain: {
-    datastore: new MemoryDatastore()
-  },
   metrics: {
     enabled: false
   },

diff --git a/src/index.js b/src/index.js
@@ -76,13 +76,12 @@ class Libp2p extends EventEmitter {
     }
 
     // Create keychain
-    if (this._options.keychain.pass) {
+    if (this._options.keychain && this._options.keychain.pass && this._options.keychain.datastore) {
       log('creating keychain')
 
-      const datastore = this._options.keychain.datastore
       const keychainOpts = Keychain.generateOptions()
 
-      this.keychain = new Keychain(datastore, {
+      this.keychain = new Keychain(this._options.keychain.datastore, {
         passPhrase: this._options.keychain.pass,
         ...keychainOpts,
         ...this._options.keychain

diff --git a/test/keychain/keychain.spec.js b/test/keychain/keychain.spec.js
@@ -416,6 +416,7 @@ describe('libp2p.keychain', () => {
       started: false,
       config: {
         keychain: {
+          datastore: new MemoryDatastore(),
           pass: '12345678901234567890'
         }
       }