chore: address review

libp2p · Nov 15, 2019 · b33aca0 · b33aca0
1 parent 340edf5
commit b33aca0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -92,7 +92,7 @@
     "libp2p-delegated-content-routing": "^0.2.2",
     "libp2p-delegated-peer-routing": "^0.2.2",
     "libp2p-floodsub": "^0.19.0",
-    "libp2p-gossipsub": "ChainSafe/gossipsub-js#refactor/async",
+    "libp2p-gossipsub": "ChainSafe/gossipsub-js#beta/async",
     "libp2p-kad-dht": "^0.15.3",
     "libp2p-mdns": "^0.12.3",
     "libp2p-mplex": "^0.9.1",

diff --git a/src/registrar.js b/src/registrar.js
@@ -6,7 +6,6 @@ const log = debug('libp2p:peer-store')
 log.error = debug('libp2p:peer-store:error')
 
 const Topology = require('libp2p-interfaces/src/topology')
-const MulticodecTopology = require('libp2p-interfaces/src/topology/multicodec-topology')
 const { Connection } = require('libp2p-interfaces/src/connection')
 const PeerInfo = require('peer-info')
 
@@ -112,8 +111,7 @@ class Registrar {
    */
   register (topology) {
     assert(
-      Topology.isTopology(topology) ||
-      MulticodecTopology.isMulticodecTopology(topology),
+      Topology.isTopology(topology),
       'topology must be an instance of interfaces/topology')
 
     // Create topology

diff --git a/test/pubsub/operation.node.js b/test/pubsub/operation.node.js
@@ -140,7 +140,10 @@ describe('Pubsub subsystem operates correctly', () => {
 
       remoteLibp2p.pubsub.start()
 
-      await pWaitFor(() => libp2p.pubsub._pubsub.peers.size === 1)
+      await pWaitFor(() =>
+        libp2p.pubsub._pubsub.peers.size === 1 &&
+        remoteLibp2p.pubsub._pubsub.peers.size === 1
+        )
 
       expect(libp2p.pubsub._pubsub.peers.size).to.be.eql(1)
       expect(remoteLibp2p.pubsub._pubsub.peers.size).to.be.eql(1)