Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(transport-webrtc) Max Message Size differs from Spec #1908

Closed
DougAnderson444 opened this issue Jul 30, 2023 · 1 comment · Fixed by #1909
Closed

bug(transport-webrtc) Max Message Size differs from Spec #1908

DougAnderson444 opened this issue Jul 30, 2023 · 1 comment · Fixed by #1909
Assignees

Comments

@DougAnderson444
Copy link
Contributor

Hi, I am reviewing the spec as I implement it in libp2p/rust-libp2p#4248 when I noticed this is not in accordance with the spec

A MUST set the a=max-message-size:16384 SDP attribute.

ref: https://github.com/libp2p/specs/blob/master/webrtc/webrtc-direct.md#browser-to-public-server

I'm not sure what the impact is as I've used js-WebRTC and it seems to work fine, but I wanted to raise the issue nontheless

maschad added a commit to maschad/js-libp2p that referenced this issue Jul 30, 2023
@maschad
Copy link
Member

maschad commented Jul 30, 2023

Thanks for spotting this @DougAnderson444 to my understanding it's an oversight, it was even mentioned on a previous issue where we discussed max message size

@maschad maschad self-assigned this Jul 30, 2023
@maschad maschad moved this to 🥸In Review in js-libp2p Jul 30, 2023
achingbrain pushed a commit that referenced this issue Jul 31, 2023
Updates max message size to comply with spec.

Closes #1908
@github-project-automation github-project-automation bot moved this from 🥸In Review to 🎉Done in js-libp2p Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants