We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
js-libp2p/packages/transport-webrtc/src/private-to-public/sdp.ts
Line 136 in a41d25d
Hi, I am reviewing the spec as I implement it in libp2p/rust-libp2p#4248 when I noticed this is not in accordance with the spec
A MUST set the a=max-message-size:16384 SDP attribute.
ref: https://github.com/libp2p/specs/blob/master/webrtc/webrtc-direct.md#browser-to-public-server
I'm not sure what the impact is as I've used js-WebRTC and it seems to work fine, but I wanted to raise the issue nontheless
The text was updated successfully, but these errors were encountered:
fix: update max message size SDP attribute (libp2p#1908)
c21821b
Thanks for spotting this @DougAnderson444 to my understanding it's an oversight, it was even mentioned on a previous issue where we discussed max message size
Sorry, something went wrong.
fix: update max message size SDP attribute (#1909)
e6a41f7
Updates max message size to comply with spec. Closes #1908
maschad
Successfully merging a pull request may close this issue.
js-libp2p/packages/transport-webrtc/src/private-to-public/sdp.ts
Line 136 in a41d25d
Hi, I am reviewing the spec as I implement it in libp2p/rust-libp2p#4248 when I noticed this is not in accordance with the spec
ref: https://github.com/libp2p/specs/blob/master/webrtc/webrtc-direct.md#browser-to-public-server
I'm not sure what the impact is as I've used js-WebRTC and it seems to work fine, but I wanted to raise the issue nontheless
The text was updated successfully, but these errors were encountered: