abstract-stream: should support undefined logger

[paralin]

Abstract stream currently requires a non-undefined logger:

• init:

  js-libp2p/packages/utils/src/abstract-stream.ts

  Line 29 in bca8d6e

  log: Logger

• implementation:

  js-libp2p/packages/utils/src/abstract-stream.ts

  Line 94 in bca8d6e

  public readonly log: Logger

• calls to this.log without a ? for undefined check:

  js-libp2p/packages/utils/src/abstract-stream.ts

  Line 196 in bca8d6e

  this.log.trace('send close write to remote')

In previous releases of js-libp2p-yamux we could pass an empty components object without a logger, but this is not possible anymore as Log is required for AbstractStream: ChainSafe/js-libp2p-yamux#69

Please make log an optional parameter for AbstractStreamInit, maybe using a no-op shim internally if necessary (when it's undefined), so that the construct for yamux()() is backwards-compatible and doesn't need to have a Logger passed every time.

The same is true for MuxerInit: it appears to now require a not-null Logger at construct time.

[achingbrain]

When libp2p configures these components it passes a logging implementation in which is why it's not optional anywhere.

Could you speak a bit more to your use case? Are you doing something different here?

[paralin]

I'm using js-libp2p-yamux externally from libp2p and don't want to pass a logger.

[paralin]

I give up on this and will just pass a stub Log from now on.