ConnectionMonitor: abortConnectionOnPingFailure is not used

[mkermani144]

• Version: 1.9.2

• Platform: Darwin / Linux

• Subsystem: Connection Monitor

Severity: Medium

Description:

There is a flag in connection manager init that is used nowhere:

js-libp2p/packages/libp2p/src/connection-monitor.ts

Lines 37 to 42 in 8639494

	/**
	* If true, any connection that fails the ping will be aborted
	*
	* @default true
	*/
	abortConnectionOnPingFailure?: boolean

While it should probably be used here:

js-libp2p/packages/libp2p/src/connection-monitor.ts

Lines 131 to 134 in 8639494

	.catch(err => {
	this.log.error('error during heartbeat, aborting connection', err)
	conn.abort(err)
	})

Steps to reproduce the error:

The flag is not used in the codebase other than the interface whose link is sent above. A global search will suffice.

[achingbrain]

Looks like using that option as a gate before aborting the connection was missed. Would you like to open a PR that implements the feature?

[mkermani144]

Seems I'm late to the party.