-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: abort connection only when abortConnectionOnPingFailure is true #2684
fix: abort connection only when abortConnectionOnPingFailure is true #2684
Conversation
Thank you for opening this. Please can you add a test to prevent future regressions? |
test cases added |
Thanks for taking this on @sumitvekariya , it seems like you have some build errors Please ensure you read through the |
Hey, apologies, I missed the build errors, I have fixed the build errors, and tested locally, build is successful and all the test cases are passed as well |
Title
fix: abort connection only when abortConnectionOnPingFailure is true
Description
#2678
This implementation does the following:
Change checklist