-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: circuitv2 #1475
[WIP] feat: circuitv2 #1475
Conversation
Thanks for picking up the branch. |
@ckousik: if there is anything to discuss verbally here, feel free to show up the the js-libp2p triage call on 2022-11-15. Many of the js-libp2p implementers are there. |
@BigLep I seemed to have missed today's js triage call. I added the wrong event to my calendar. Currently, I'm picking up from where @mpetrunic left off and have added a simple procedure to clear stale reservations and merged in the latest changes from master into this branch. I have manually tested this against the Go implementation using the examples/auto-relay dialer and listener scripts and currently waiting for review. We need this implementation as a pre-requisite for browser-to-browser connections using the webrtc transport. |
@achingbrain Squashing all of the above comments is proving quite difficult. Also, the current code disables circuit v1 completely (ref: https://github.com/libp2p/js-libp2p/pull/1475/files#diff-22c4eb6dd642d67acce49c5271427768070be6c5ad11b1cc2a23a0b11fba04fcR160). I feel it might be faster to rewrite circuit-v2 from the current master branch. |
@ckousik maybe we can discuss this with @achingbrain @mpetrunic and all during the next js-libp2p triage |
closed in favor of #1533 |
Continues the circuit v2 implementation from #1166 .
Interop testing: