avoid constructor.name . fix for #65 #177
Conversation
| @@ -129,7 +130,7 @@ class Node extends EventEmitter { | |||
| this.switch.transport.add( | |||
| transport.tag || transport.constructor.name, transport) | |||
| } else if (transport.constructor && | |||
| transport.constructor.name === 'WebSockets') { | |||
| transport instanceof WebSockets) { | |||
There was a problem hiding this comment.
Same feedback as multiformats/js-multiaddr#55 (comment)
There was a problem hiding this comment.
@diasdavid hey,
solution 1 : What if we add a name property to the WebSockets class which isn't gonna be mangled by uglify like so
class WebSockets {
constructor (opts) {
this.name = 'WebSockets'
}
}Solution 2 : use both instanceOf and constructor,name like so
if (transport.constructor.name === 'WebSockets' || transport instanceOf WebSockets)
What do you think.??
There was a problem hiding this comment.
solution 1 is closer to a real solution. Even better would be just to have a isWebSockets method that checks multiple things
|
See @pgte proposal ipfs/js-ipfs#1131 (comment) |
daviddias
added
help wanted
|
PR #182 fixes this. |
|
This has been fixed in all the js-ipfs deps thanks to @fsdiogo. @ya7ya thanks for helping us diagnose and provide solutions. Check ipfs/js-ipfs#1321 for more info. |
this avoids using
constructor.nameso uglify can mangle and compressjs-ipfsproperly.this should close #65
cc @diasdavid