Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not overwrite addresses on identify push when none are sent #2192

Merged
merged 3 commits into from
Nov 3, 2023

Commits on Nov 2, 2023

  1. fix: do not overwrite addresses on identify push when none are sent

    During identify-push in response to a protocol update go-libp2p does not send a signed peer record or the current list of listen addresses.
    
    Protobuf does not let us differentiate between an empty list and no list items at all because the field is just repeated - an absence of repeated fields doesn't mean the list was omitted.
    
    When the listen address list is empty, preserve any existing addresses.
    achingbrain committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    268c42b View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. chore: fix up merging

    achingbrain committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    23a703c View commit details
    Browse the repository at this point in the history
  2. chore: linting

    achingbrain committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6711289 View commit details
    Browse the repository at this point in the history