Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable interop tests temporarily #2285

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Dec 1, 2023

Gossipsub depending on an older version of @libp2p/interface and @libp2p/interface-internal seems to mess up npm's workspace dependency hoisting so remove them until Gossipsub is updated.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Gossipsub depending on an older version of `@libp2p/interface` and
`@libp2p/interface-internal` seems to mess up npm's workspace
dependency hoisting to remove them until Gossipsub is updated.
@achingbrain achingbrain requested a review from a team as a code owner December 1, 2023 14:50
@achingbrain achingbrain merged commit 7861ed8 into main Dec 1, 2023
17 checks passed
@achingbrain achingbrain deleted the chore/disable-interop-tests branch December 1, 2023 15:08
achingbrain added a commit that referenced this pull request Dec 4, 2023
Now that gossipsub has been updated, revert changes from #2285
@achingbrain achingbrain mentioned this pull request Dec 4, 2023
3 tasks
achingbrain added a commit that referenced this pull request Dec 5, 2023
Now that gossipsub has been updated, revert changes from #2285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant