Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add versions of peer lists/sets/maps that report their sizes #2300

Merged
merged 4 commits into from
Dec 5, 2023
Merged

feat: add versions of peer lists/sets/maps that report their sizes #2300

merged 4 commits into from
Dec 5, 2023

Conversation

achingbrain
Copy link
Member

Adds peer collections that report their sizes to the libp2p metrics service.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: add versions of peer lists/sets/maps that report their sizes
4dc3de0 
Adds collections that report their sizes to the libp2p metrics service.
@achingbrain achingbrain requested a review from a team as a code owner December 5, 2023 16:07
maschad
maschad requested changes Dec 5, 2023
View reviewed changes
packages/peer-collections/src/index.ts Outdated Show resolved Hide resolved
packages/peer-collections/src/index.ts Outdated Show resolved Hide resolved
packages/peer-collections/src/index.ts Outdated Show resolved Hide resolved
packages/peer-collections/src/tracked-list.ts Outdated Show resolved Hide resolved
packages/peer-collections/src/tracked-map.ts Outdated Show resolved Hide resolved
packages/peer-collections/src/tracked-set.ts Outdated Show resolved Hide resolved
@achingbrain @maschad
chore: apply suggestions from code review
3fcc985 
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
@achingbrain achingbrain merged commit 57944fa into main Dec 5, 2023
22 checks passed
@achingbrain achingbrain deleted the feat/add-tracked-peer-collections branch December 5, 2023 17:51
@achingbrain achingbrain mentioned this pull request Dec 5, 2023
Merged
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @maschad