fix!: remove localPeer from secureInbound and secureOutbound #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked waiting for the next breaking change milestone |
SgtPooki
reviewed
Aug 9, 2024
| encrypter.secureInbound(remotePeer, inbound), | ||
| encrypter.secureOutbound(localPeer, outbound, wrongPeer) | ||
| encrypter.secureInbound(inbound, remotePeer), | ||
| encrypter.secureOutbound(outbound, wrongPeer) |
There was a problem hiding this comment.
Curious, do we need an encrypterRemote here like we have in packages/connection-encrypter-plaintext/test/index.spec.ts ?
If we can do either/or, it would be nice to use the same setup to not cause confusion and questions like this one :)
If we can't, maybe a comment explaining why? (maybe only for libp2p noobs like myself)
There was a problem hiding this comment.
It would make the test easier to read but this encrypter is stateless which is why it works as-is.
Comment on lines
+57
to
+58
| cryptoRemote.secureInbound(localConn), | ||
| crypto.secureOutbound(remoteConn, remotePeer) |
There was a problem hiding this comment.
similar question about dissimilarities between encrypters we create&call for secureInbound and secureOutbound calls
achingbrain
approved these changes
Aug 14, 2024
achingbrain
added a commit
that referenced
this pull request
Sep 6, 2024
Requiring the local peer id in connection encryption appears to be historical cruft. The more current approach would be to have a `ConnectionEncrypter` be specific to a single peer id, passed in during instantiation in its Components. BREAKING CHANGE: removes `localPeer: PeerId` first parameter from `secureInbound` and `secureOutbound` in `ConnectionEncrypter` --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain
added a commit
that referenced
this pull request
Sep 6, 2024
Requiring the local peer id in connection encryption appears to be historical cruft. The more current approach would be to have a `ConnectionEncrypter` be specific to a single peer id, passed in during instantiation in its Components. BREAKING CHANGE: removes `localPeer: PeerId` first parameter from `secureInbound` and `secureOutbound` in `ConnectionEncrypter` --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain
added a commit
that referenced
this pull request
Sep 6, 2024
Requiring the local peer id in connection encryption appears to be historical cruft. The more current approach would be to have a `ConnectionEncrypter` be specific to a single peer id, passed in during instantiation in its Components. BREAKING CHANGE: removes `localPeer: PeerId` first parameter from `secureInbound` and `secureOutbound` in `ConnectionEncrypter` --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
localPeer: PeerIdfirst parameter fromsecureInboundandsecureOutboundinConnectionEncrypterRequiring the local peer id in connection encryption appears to be historical cruft. The more current approach would be to have a
ConnectionEncrypterbe specific to a single peer id, passed in during instantiation in its Components.Change checklist