Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make peerid optional in peerid.equals #2335

Merged
merged 2 commits into from
Dec 28, 2023
Merged

fix: make peerid optional in peerid.equals #2335

merged 2 commits into from
Dec 28, 2023

Conversation

achingbrain
Copy link
Member

This makes the code a bit more flexible, for example when taking action based on an optional peerid having been passed to a function when an existing peer id is known.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: make peerid optional in peerid.equals
6a25489 
This makes the code a bit more flexible, for example when taking
action based on an optional peerid having been passed to a function
when an existing peer id is known.
@achingbrain achingbrain requested a review from a team as a code owner December 28, 2023 06:36
@achingbrain achingbrain merged commit f1c1167 into main Dec 28, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/allow-passing-undefined-to-peer-id-equals branch December 28, 2023 07:38
@achingbrain achingbrain mentioned this pull request Dec 28, 2023
Merged
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain