Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sinon matchers for PeerIds and Multiaddrs to test module #2373

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

achingbrain
Copy link
Member

To allow matching PeerId/Multiaddrs by value (not just by reference) add reusable matchers to the compliance test module.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

To allow matching PeerId/Multiaddrs by value (not just by reference)
add reusible matchers to the compliance test module.
@achingbrain achingbrain requested a review from a team as a code owner January 24, 2024 10:40
@achingbrain achingbrain merged commit 2e464c0 into main Jan 24, 2024
21 checks passed
@achingbrain achingbrain deleted the feat/add-peer-multiaddr-matchers branch January 24, 2024 12:05
@achingbrain achingbrain mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant