Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check service dependencies on startup #2586

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

achingbrain
Copy link
Member

Allows services to optionally define the capabilities they provide to the rest of libp2p and also the capabilities they require from other services.

This allows, for example, the WebRTC transport to require the CircuitRelay transport to be present, or KAD-DHT (or anything that uses a topology) to require the identify protocol.

Fixes #2263 Refs #2135

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner June 12, 2024 10:32
@achingbrain achingbrain force-pushed the feat/check-service-dependencies-on-startup branch from 7eaa025 to 4b23377 Compare June 12, 2024 11:05
Allows services to optionally define the capabilities they provide to the
rest of libp2p and also the capabilities they require from other services.

This allows, for example, the `WebRTC` transport to require the `CircuitRelay`
transport to be present, or `KAD-DHT` (or anything that uses a topology)
to require the identify protocol.

Fixes #2263
Refs #2135
@achingbrain achingbrain force-pushed the feat/check-service-dependencies-on-startup branch from 4b23377 to db7d5e5 Compare June 12, 2024 11:07
@achingbrain achingbrain force-pushed the feat/check-service-dependencies-on-startup branch from f1f5b50 to 74621ea Compare June 12, 2024 16:49
@achingbrain achingbrain merged commit d1f1c2b into main Jun 13, 2024
24 checks passed
@achingbrain achingbrain deleted the feat/check-service-dependencies-on-startup branch June 13, 2024 08:31
@achingbrain achingbrain mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Ensure services indicate their dependencies through identifiers
1 participant