Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add url peer id #2598

Merged
merged 3 commits into from
Jul 2, 2024
Merged

feat: add url peer id #2598

merged 3 commits into from
Jul 2, 2024

Conversation

achingbrain
Copy link
Member

To parse non-cryptographic peer ids from http servers, add the url peer id type.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: add url peer id
2dc89db 
To parse non-cryptographic peer ids from http servers, add the
url peer id type.
@achingbrain achingbrain requested a review from a team as a code owner June 20, 2024 15:09
maschad
maschad requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are some type incompatibilities in peer-id-factory

@achingbrain achingbrain merged commit b0b6cae into main Jul 2, 2024
24 checks passed
@achingbrain achingbrain deleted the feat/add-url-peer-id branch July 2, 2024 12:27
@achingbrain achingbrain mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @maschad