fix!: remove CustomEvent export from @libp2p/interface
#2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CustomEvent` is global in Node.js as of `v18.7.0`. We support LTS and Current which means `v20+`, and Electron has upgraded to node 20 so the polyfill isn't necessary any more. BREAKING CHANGE: `@libp2p/interface` no longer exports a `CustomEvent` polyfill
27 tasks
|
@achingbrain Should we temporarily disable the interop tests in this PR and then re-enable once gossipsub upgrades it's |
|
@maschad it shouldn't be necessary - when ChainSafe/js-libp2p-gossipsub#500 is merged gossipsub will use the global |
xendarboh
added a commit
to 0KnowledgeNetwork/appchain-agent
that referenced
this pull request
Aug 26, 2024
We're on nodejs v18 until o1js/protokit upgrades. @libp2p says: "We support LTS and Current which means v20+" Related: - libp2p/js-libp2p#2656 - libp2p/js-libp2p#2652 Fixes error: TypeError: CustomEvent is not a constructor at TypedEventEmitter.safeDispatchEvent (file:///.../appchain-agent/node_modules/.pnpm/@libp2p+interface@1.7.0/node_modules/@libp2p/interface/dist/src/event-target.js:53:35)
|
I am using NodeJS 18.20.4 and get "CustomEvent is not a constructor" error. But works with NodeJS 20. Have some version of 18 been verified to work? |
|
@marcus-pousette --experimental-global-customevent seems to work for me, but when I import 'node:events' I don't see it on 18.15.0 |
achingbrain
added a commit
that referenced
this pull request
Sep 6, 2024
`CustomEvent` is global in Node.js as of `v18.7.0`. We support LTS and Current which means `v20+`, and Electron has upgraded to node 20 so the polyfill isn't necessary any more. BREAKING CHANGE: `@libp2p/interface` no longer exports a `CustomEvent` polyfill
achingbrain
added a commit
that referenced
this pull request
Sep 6, 2024
`CustomEvent` is global in Node.js as of `v18.7.0`. We support LTS and Current which means `v20+`, and Electron has upgraded to node 20 so the polyfill isn't necessary any more. BREAKING CHANGE: `@libp2p/interface` no longer exports a `CustomEvent` polyfill
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomEventis global in Node.js as ofv18.7.0. We support LTS and Current which meansv20+, and Electron has upgraded to node 20 so the polyfill isn't necessary any more.BREAKING CHANGE:
@libp2p/interfaceno longer exports aCustomEventpolyfillChange checklist