Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add auto-confirm option to auto-tls #2875

Merged
merged 2 commits into from
Dec 6, 2024
Merged

feat: add auto-confirm option to auto-tls #2875

merged 2 commits into from
Dec 6, 2024

Conversation

achingbrain
Copy link
Member

Adds an autoConfirmAddress to trust that the libp2p.direct DNS addresses have been configured correctly without waiting for autonat to verify. Defaults to false.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: add auto-confirm option to auto-tls
2cda67d 
Adds an `autoConfirmAddress` to trust that the `libp2p.direct` DNS
addresses have been configured correctly without waiting for
autonat to verify. Defaults to `false`.
@achingbrain achingbrain requested a review from a team as a code owner December 6, 2024 10:55
@achingbrain achingbrain merged commit 2625cc3 into main Dec 6, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the feat/add-auto-confirm-to-auto-tls branch December 6, 2024 12:28
@achingbrain achingbrain mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain