-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate gossipsub by default #365
Conversation
3fc3adc
to
e753125
Compare
e753125
to
e238d43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments, but overall this looks good.
4edf353
to
4dd2e46
Compare
913c809
to
34f663a
Compare
9c48b1b
to
2b76101
Compare
1dd19c2
to
3790ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 usability thing with configuration, otherwise I like where this is at.
src/index.js
Outdated
if (this._config.EXPERIMENTAL.pubsub) { | ||
this.pubsub = pubsub(this) | ||
// start pubsub | ||
if (this._config.pubsub.enabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasco-santos what do you think about changing this logic a bit. I think if this._modules.pubsub
is set, and this._config.pubsub.enabled !== false
we should use pubsub. This would avoid people needing to add and enable it. We do this for discovery. If you've configured it, there's a really good chance you want to use it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this is a better dev ex
e45b1bb
to
c2cd663
Compare
BREAKING CHANGE: new configuration for deciding the implementation of pubsub to be used. In this context, the experimental flags were also removed.
c5be8dd
to
65866b2
Compare
@jacobheun gossipsub was released 🎉 Just rebased and updated the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot! I'll get an rc cut.
0.26.0-rc.0 is out! |
BREAKING CHANGE: new configuration for deciding the implementation of pubsub to be used.
In this context, the experimental flags were also removed.
This PR modified the configuration of a libp2p node, in order to allow the selection of the pubsub implementation to use. Also Gossipsub was added as the default pubsub implementation in the tests
Needs:
gossipsub-js
Unblocks: