Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add core modules to libp2p #400

Merged
merged 19 commits into from
Aug 16, 2019

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Aug 8, 2019

Resolves #384

Modules

Cleanup

  • Consolidate tests
  • Consolidate util functions
  • Remove or minimize the package.json files of the merged repos
  • Clean up the READMEs

Co-Authors

Connection Mananger

Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Pedro Teixeira <i@pgte.me>
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>

Identify

Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Maciej Krüger <mkg20001@gmail.com>
Co-authored-by: Richard Littauer <richard.littauer@gmail.com>
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
Co-authored-by: Yusef Napora <yusef@protocol.ai>
Co-authored-by: ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ <victorbjelkholm@gmail.com>

Pnet

Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>

Ping

Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Francisco Baio Dias <xicombd@gmail.com>
Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com>
Co-authored-by: Hugo Dias <mail@hugodias.me>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: João Antunes <j.goncalo.antunes@gmail.com>
Co-authored-by: Richard Littauer <richard.littauer@gmail.com>
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
Co-authored-by: ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ <victorbjelkholm@gmail.com>

Circuit

Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Dmitriy Ryajov <dryajov@gmail.com>
Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com>
Co-authored-by: Hugo Dias <mail@hugodias.me>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Jacob Heun <jake@andyet.net>
Co-authored-by: Maciej Krüger <mkg20001@gmail.com>
Co-authored-by: Oli Evans <oli@tableflip.io>
Co-authored-by: Pedro Teixeira <i@pgte.me>
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
Co-authored-by: Victor Bjelkholm <victorbjelkholm@gmail.com>
Co-authored-by: Yusef Napora <yusef@napora.org>
Co-authored-by: dirkmc <dirk@mccormick.cx>

@jacobheun jacobheun force-pushed the refactor/core-modules branch 5 times, most recently from 14b5f8a to c394bf2 Compare August 14, 2019 17:26
@jacobheun
Copy link
Contributor Author

I am postponing js-libp2p-keychain and js-libp2p-nat-mngr for subsequent PRs. Keychain is currently only used externally. It makes sense to pull this into js-libp2p, but this will be an API change, as we will likely move that under libp2p.keychain. As such, this should be done separately, imo.
Nat Manager isn't ready yet, so it doesn't make sense to pull it into master. That should be pulled in when it's initial iteration is ready for use.

I've done some test de duplication, but I am avoiding removing too much as part of this. I think it is safer and makes more sense to do the components as individual PRs, so that the changes are easier to follow. This could also be a good opportunity to clean up tests for each component as those pieces are migrated to async/await.

@jacobheun jacobheun marked this pull request as ready for review August 15, 2019 12:17
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jacobheun and others added 19 commits August 16, 2019 17:01
Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Pedro Teixeira <i@pgte.me>
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Maciej Krüger <mkg20001@gmail.com>
Co-authored-by: Richard Littauer <richard.littauer@gmail.com>
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
Co-authored-by: Yusef Napora <yusef@protocol.ai>
Co-authored-by: ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ <victorbjelkholm@gmail.com>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Francisco Baio Dias <xicombd@gmail.com>
Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com>
Co-authored-by: Hugo Dias <mail@hugodias.me>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: João Antunes <j.goncalo.antunes@gmail.com>
Co-authored-by: Richard Littauer <richard.littauer@gmail.com>
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
Co-authored-by: ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ <victorbjelkholm@gmail.com>
Co-authored-by: David Dias <daviddias.p@gmail.com>
Co-authored-by: Dmitriy Ryajov <dryajov@gmail.com>
Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com>
Co-authored-by: Hugo Dias <mail@hugodias.me>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Maciej Krüger <mkg20001@gmail.com>
Co-authored-by: Oli Evans <oli@tableflip.io>
Co-authored-by: Pedro Teixeira <i@pgte.me>
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
Co-authored-by: Victor Bjelkholm <victorbjelkholm@gmail.com>
Co-authored-by: Yusef Napora <yusef@napora.org>
Co-authored-by: dirkmc <dirk@mccormick.cx>
@jacobheun jacobheun merged commit b294301 into libp2p:master Aug 16, 2019
@jacobheun jacobheun deleted the refactor/core-modules branch August 16, 2019 15:30
jacobheun added a commit that referenced this pull request Aug 21, 2019
The get peer info util consolidation from #400 exposed an issue
with how bad values are being handled. Throwing the error can cause
issues when promises are being used. Rejecting resolves this.
I added a test case to validate the change.
jacobheun added a commit that referenced this pull request Aug 21, 2019
The get peer info util consolidation from #400 exposed an issue
with how bad values are being handled. Throwing the error can cause
issues when promises are being used. Rejecting resolves this.
I added a test case to validate the change.
@daviddias
Copy link
Member

This is really great work @jacobheun! Thank you so much for owning it ❤️

I see that the modules that have been merged, haven't gotten a deprecation notice and a redirect to this one instead. Also, the table should be updated https://github.com/libp2p/js-libp2p#packages

@jacobheun
Copy link
Contributor Author

@daviddias yes! This is on my list to do this week, although I will likely need to have an org admin do some of this as archiving and description modifications are outside of my perms list. I'll put together a list of things that need to be done and hand off the pieces I need perms support for.

@daviddias
Copy link
Member

I've went ahead and helped by moving all the outstanding issues to js-libp2p so that they are not lost (and updating the title so that it is easy to know where they came from). I've also disabled issues on those repos to avoid the creation of new ones.

Happy to do the Org Admin stuff once the PRs and deprecation notices (both in the repo and in npm) are done. Just ping me :)

@hugomrdias
Copy link
Member

just wanted to say AWESOME WORK thank you 🙏

maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
* deps: bump private-ip from 2.3.4 to 3.0.0

Bumps [private-ip](https://github.com/frenchbread/private-ip) from 2.3.4 to 3.0.0.
- [Release notes](https://github.com/frenchbread/private-ip/releases)
- [Commits](frenchbread/private-ip@2.3.4...3.0.0)

---
updated-dependencies:
- dependency-name: private-ip
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: fix linting

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <alex@achingbrain.net>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge js-libp2p-{core pieces} into js-libp2p repo
4 participants