-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add core modules to libp2p #400
Conversation
14b5f8a
to
c394bf2
Compare
I am postponing js-libp2p-keychain and js-libp2p-nat-mngr for subsequent PRs. Keychain is currently only used externally. It makes sense to pull this into js-libp2p, but this will be an API change, as we will likely move that under I've done some test de duplication, but I am avoiding removing too much as part of this. I think it is safer and makes more sense to do the components as individual PRs, so that the changes are easier to follow. This could also be a good opportunity to clean up tests for each component as those pieces are migrated to async/await. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: David Dias <daviddias.p@gmail.com> Co-authored-by: Jacob Heun <jacobheun@gmail.com> Co-authored-by: Pedro Teixeira <i@pgte.me> Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
Co-authored-by: David Dias <daviddias.p@gmail.com> Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com> Co-authored-by: Hugo Dias <hugomrdias@gmail.com> Co-authored-by: Jacob Heun <jacobheun@gmail.com> Co-authored-by: Maciej Krüger <mkg20001@gmail.com> Co-authored-by: Richard Littauer <richard.littauer@gmail.com> Co-authored-by: Vasco Santos <vasco.santos@moxy.studio> Co-authored-by: Yusef Napora <yusef@protocol.ai> Co-authored-by: ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ <victorbjelkholm@gmail.com>
Co-authored-by: Jacob Heun <jacobheun@gmail.com> Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
Co-authored-by: David Dias <daviddias.p@gmail.com> Co-authored-by: Francisco Baio Dias <xicombd@gmail.com> Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com> Co-authored-by: Hugo Dias <mail@hugodias.me> Co-authored-by: Jacob Heun <jacobheun@gmail.com> Co-authored-by: João Antunes <j.goncalo.antunes@gmail.com> Co-authored-by: Richard Littauer <richard.littauer@gmail.com> Co-authored-by: Vasco Santos <vasco.santos@moxy.studio> Co-authored-by: Vasco Santos <vasco.santos@ua.pt> Co-authored-by: ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ <victorbjelkholm@gmail.com>
Co-authored-by: David Dias <daviddias.p@gmail.com> Co-authored-by: Dmitriy Ryajov <dryajov@gmail.com> Co-authored-by: Friedel Ziegelmayer <dignifiedquire@gmail.com> Co-authored-by: Hugo Dias <mail@hugodias.me> Co-authored-by: Jacob Heun <jacobheun@gmail.com> Co-authored-by: Maciej Krüger <mkg20001@gmail.com> Co-authored-by: Oli Evans <oli@tableflip.io> Co-authored-by: Pedro Teixeira <i@pgte.me> Co-authored-by: Vasco Santos <vasco.santos@ua.pt> Co-authored-by: Victor Bjelkholm <victorbjelkholm@gmail.com> Co-authored-by: Yusef Napora <yusef@napora.org> Co-authored-by: dirkmc <dirk@mccormick.cx>
e2bc987
to
0ed470c
Compare
The get peer info util consolidation from #400 exposed an issue with how bad values are being handled. Throwing the error can cause issues when promises are being used. Rejecting resolves this. I added a test case to validate the change.
The get peer info util consolidation from #400 exposed an issue with how bad values are being handled. Throwing the error can cause issues when promises are being used. Rejecting resolves this. I added a test case to validate the change.
This is really great work @jacobheun! Thank you so much for owning it ❤️ I see that the modules that have been merged, haven't gotten a deprecation notice and a redirect to this one instead. Also, the table should be updated https://github.com/libp2p/js-libp2p#packages |
@daviddias yes! This is on my list to do this week, although I will likely need to have an org admin do some of this as archiving and description modifications are outside of my perms list. I'll put together a list of things that need to be done and hand off the pieces I need perms support for. |
I've went ahead and helped by moving all the outstanding issues to js-libp2p so that they are not lost (and updating the title so that it is easy to know where they came from). I've also disabled issues on those repos to avoid the creation of new ones. Happy to do the Org Admin stuff once the PRs and deprecation notices (both in the repo and in npm) are done. Just ping me :) |
just wanted to say AWESOME WORK thank you 🙏 |
* deps: bump private-ip from 2.3.4 to 3.0.0 Bumps [private-ip](https://github.com/frenchbread/private-ip) from 2.3.4 to 3.0.0. - [Release notes](https://github.com/frenchbread/private-ip/releases) - [Commits](frenchbread/private-ip@2.3.4...3.0.0) --- updated-dependencies: - dependency-name: private-ip dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore: fix linting Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: achingbrain <alex@achingbrain.net>
## [6.0.3](libp2p/js-libp2p-kad-dht@v6.0.2...v6.0.3) (2022-12-07) ### Dependencies * bump private-ip from 2.3.4 to 3.0.0 ([libp2p#400](libp2p/js-libp2p-kad-dht#400)) ([5a567e3](libp2p/js-libp2p-kad-dht@5a567e3))
Resolves #384
Modules
- [ ] js-libp2p-keychain- [ ] js-libp2p-nat-mngrjs-libp2p-switchdone via refactor: add js-libp2p-switch to the libp2p codebase #388Cleanup
Co-Authors
Connection Mananger
Identify
Pnet
Ping
Circuit