fix: config validation #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
This fixes a bug where `ADD_PROVIDER` message keys were CID bytes instead of multihash bytes, and changes the CIDs generated in tests to be V1s with `raw` codec instead of V0s so that the difference is actually tested. Fixes libp2p#381
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [6.0.4](libp2p/js-libp2p-kad-dht@v6.0.3...v6.0.4) (2022-12-07) ### Bug Fixes * use multihash bytes for provide message keys ([libp2p#405](libp2p/js-libp2p-kad-dht#405)) ([d7e7b5d](libp2p/js-libp2p-kad-dht@d7e7b5d)), closes [libp2p#381](libp2p/js-libp2p-kad-dht#381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to the 0.25.x line. I will also create a PR to apply this to the 0.26 line
interfacemethod, as their recent release of 0.6.2 breaks how we're doing validation. The config is now a bit looser with how it's checking things now. We will migrate away from superstruct in a future PR, Update configuration validation (remove superstruct) #406.