feat: peer store #470
Merged
feat: peer store #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/peer-store
branch
from
28b3b06
to
284db17
Compare
Merged
vasco-santos
force-pushed
the
feat/peer-store
branch
from
284db17
to
3468fca
Compare
jacobheun
suggested changes
Nov 4, 2019
| const peerInfo = getPeerInfo(connection.remotePeer) | ||
|
|
||
| peerInfo.protocols.add(stream.protocol) | ||
| this.peerStore.put(peerInfo) |
There was a problem hiding this comment.
This will only put to the peer store if protocols are given. If .dial is called, it calls .dialProtocol in turn without protocols, so the peer info might not get saved
vasco-santos
force-pushed
the
feat/peer-store
branch
from
170ead1
to
51a23d6
Compare
vasco-santos
force-pushed
the
feat/peer-store
branch
from
51a23d6
to
1c77705
Compare
vasco-santos
force-pushed
the
feat/peer-store
branch
from
1c77705
to
83c6cde
Compare
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
vasco-santos
force-pushed
the
feat/peer-store
branch
from
83c6cde
to
2f1f2c7
Compare
jacobheun
approved these changes
Nov 6, 2019
dirkmc
pushed a commit
that referenced
this pull request
Nov 26, 2019
* feat: peer-store v0 * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
dirkmc
pushed a commit
that referenced
this pull request
Nov 26, 2019
* feat: peer-store v0 * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
added a commit
that referenced
this pull request
Dec 12, 2019
* feat: peer-store v0 * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* feat: peer-store v0 * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Otherwise the log displays `[object Object]`
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [9.1.5](libp2p/js-libp2p-kad-dht@v9.1.4...v9.1.5) (2023-05-05) ### Bug Fixes * log peer id not whole object ([libp2p#470](libp2p/js-libp2p-kad-dht#470)) ([e9efb7f](libp2p/js-libp2p-kad-dht@e9efb7f)) * only choose query peers after initial self-query has run ([libp2p#471](libp2p/js-libp2p-kad-dht#471)) ([4d05154](libp2p/js-libp2p-kad-dht@4d05154))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of
peer-store, which will replace libp2p/js-peer-book, using the same name asgo-libp2p, being this the initial step for libp2p/js-libp2p#453, as well as for the new version ofpeer-store, which we will be working on after the refactor.Work extracted from #467