feat: peer store operations has, get and remove should support peer id instances #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
approved these changes
Dec 2, 2019
jacobheun
deleted the
feat/peer-store-operationshas-get-remove-should-support-peer-id-instances
branch
jacobheun
pushed a commit
that referenced
this pull request
Dec 12, 2019
jacobheun
pushed a commit
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to support
base32peer identifiers as a default in the future, we should supportpeer-storeoperations with thepeer-idinstance instead of its string representation.For now I did not deprecate the string representation since we have several modules using it. However, I will create an issue to deprecate it in the future