Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop discoveries #530

Merged
merged 3 commits into from
Jan 7, 2020
Merged

fix: stop discoveries #530

merged 3 commits into from
Jan 7, 2020

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jan 7, 2020

No description provided.

jacobheun
jacobheun approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I went ahead and added a test to avoid future regressions.

@jacobheun jacobheun merged commit c44e6e3 into refactor/async-await Jan 7, 2020
@jacobheun jacobheun deleted the fix/stop-discoveries branch January 7, 2020 15:27
jacobheun added a commit that referenced this pull request Jan 24, 2020
@jacobheun
fix: stop discoveries (#530)
4222c49 
* fix: stop discoveries

* test: add discovery stop test

* chore: fix lint

Co-authored-by: Jacob Heun <jacobheun@gmail.com>
@snyk-bot snyk-bot mentioned this pull request Mar 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @jacobheun