feat: exchange signed peer records in identify #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2020
Closed
jacobheun
reviewed
Jun 23, 2020
vasco-santos
force-pushed
the
feat/exchange-signed-peer-records-in-identify
branch
from
fd20b89
to
12022ab
Compare
3 tasks
vasco-santos
force-pushed
the
feat/exchange-signed-peer-records-in-identify
branch
3 times, most recently
from
1b3bd46
to
93966b9
Compare
jacobheun
force-pushed
the
0.29.x
branch
2 times, most recently
from
a947283
to
4792ebb
Compare
vasco-santos
force-pushed
the
feat/exchange-signed-peer-records-in-identify
branch
3 times, most recently
from
3dc300d
to
e3bd773
Compare
vasco-santos
force-pushed
the
feat/exchange-signed-peer-records-in-identify
branch
from
e3bd773
to
c2fa11a
Compare
jacobheun
reviewed
Jul 15, 2020
src/identify/consts.js
Outdated
| module.exports.MULTICODEC_IDENTIFY = '/ipfs/id/1.0.0' | ||
| module.exports.MULTICODEC_IDENTIFY_PUSH = '/ipfs/id/push/1.0.0' | ||
| module.exports.MULTICODEC_IDENTIFY = '/p2p/id/1.1.0' | ||
| module.exports.MULTICODEC_IDENTIFY_PUSH = '/p2p/id/push/1.1.0' |
There was a problem hiding this comment.
Where are the versions listed, I was having trouble finding the updates. Is this in the specs repo or in go-libp2p?
There was a problem hiding this comment.
This commit added them: libp2p/go-libp2p@077a818#diff-98be6dba669aa4123b7ef190fe7113e8
However, now that I looked further, the same protocol is now being used and go reverted this change per libp2p/go-libp2p#907 (comment)
I am doing the same
src/identify/index.js
Outdated
| @@ -172,8 +183,40 @@ class IdentifyService { | |||
| // Get the observedAddr if there is one | |||
| observedAddr = IdentifyService.getCleanMultiaddr(observedAddr) | |||
|
|
|||
| // LEGACY: differentiate message with SignedPeerRecord | |||
| if (protocol === MULTICODEC_IDENTIFY_1_0_0) { | |||
There was a problem hiding this comment.
No need to check the protocol, I'd just check the existence of signedPeerRecord. I think it might be better to catch and log the errors unmarshalling the signed peer record and then fallback to adding the listenAddrs. If for some reason the payload is malformed this will allow us to easily fallback.
vasco-santos
force-pushed
the
feat/exchange-signed-peer-records-in-identify
branch
from
c2a8b86
to
d67190b
Compare
jacobheun
reviewed
Jul 15, 2020
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
force-pushed
the
feat/exchange-signed-peer-records-in-identify
branch
3 times, most recently
from
d76fe0c
to
931b71b
Compare
vasco-santos
force-pushed
the
feat/exchange-signed-peer-records-in-identify
branch
from
eaafd44
to
d935021
Compare
jacobheun
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the exchange of signed peer records in identify as part of #653
Needs:
In the context of using signed peer records on identify, the protocols were updated
For the time being,
js-libp2pwill fallback to the legacy protocols if the negotiated stream is using them, so that we stil have compatibility with peers using older versions of libp2p.This PR will have a follow up PR to store the certified multiaddrs properly, as the multiaddrs are still being stored in the AddressBook as a regular multiaddr discovered.