100% coverage #15
Merged
100% coverage #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! :D Could you add a coverage badge as well? |
|
Oh hah, I didn't realize you had to manually edit that. Seems like maybe more work than it's worth? We could just drop it now that we're at 100%. |
|
Thank you :) We could use a service. But that requires configuring another service, which we could, just takes time, which is also ok to take the time, if you want to get it :) Static coverage badges are a 'normal' (not standard) practice too and it gives confidence to our users that we have covered it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses ipfs/js-ipfs#117