Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Commit

Permalink
fix: use forge bundle for libp2p-crypto
Browse files Browse the repository at this point in the history
  • Loading branch information
@dignifiedquire
dignifiedquire committed May 26, 2016
1 parent c6ff576 commit 76c3495
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 29,561 deletions.
16 changes: 16 additions & 0 deletions .aegir.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict'

const path = require('path')

module.exports = {
webpack: {
resolve: {
alias: {
'node-forge': path.resolve(
path.dirname(require.resolve('libp2p-crypto')),
'../vendor/forge.bundle.js'
)
}
}
}

This comment has been minimized.

Sign in to view

Copy link
@daviddias

daviddias May 26, 2016 •
edited
Loading

Member

so this is the new way that has to be applied to all repos?
@dignifiedquire
}
9 changes: 0 additions & 9 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,6 @@
"babel-runtime": "^6.6.1",
"peer-id": "^0.7.0"
},
"aegir": {
"webpack": {
"resolve": {
"alias": {
"node-forge": "../vendor/forge.bundle.js"
}
}
}
},
"contributors": [
"David Dias <daviddias.p@gmail.com>",
"David Dias <mail@daviddias.me>",
Expand Down
Loading

2 comments on commit 76c3495

@dignifiedquire
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but it's more efficient and less brittle. the other broke bot of aegir bot because the file path of the file requiring node-forge changed making the relative path used invalid.

@daviddias
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. so that means that we should probably include that .aegir on the guidelines too?

Please sign in to comment.