protocols/gossipsub: Fix elided lifetime on gossipsub config builder (#…

…2409) Co-authored-by: Max Inden <mail@max-inden.de>
libp2p · Dec 30, 2021 · 3749dd5 · 3749dd5
1 parent b4468d7
commit 3749dd5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/protocols/gossipsub/CHANGELOG.md b/protocols/gossipsub/CHANGELOG.md
@@ -9,9 +9,12 @@
 - Improve bandwidth performance by tracking IWANTs and reducing duplicate sends
   (see [PR 2327]).
 
+- Fix `GossipsubConfigBuilder::build()` requiring `&self` to live for `'static` (see [PR 2409])
+
 [PR 2346]: https://github.com/libp2p/rust-libp2p/pull/2346
 [PR 2339]: https://github.com/libp2p/rust-libp2p/pull/2339
 [PR 2327]: https://github.com/libp2p/rust-libp2p/pull/2327
+[PR 2409]: https://github.com/libp2p/rust-libp2p/pull/2409
 
 # 0.34.0 [2021-11-16]
 

diff --git a/protocols/gossipsub/src/config.rs b/protocols/gossipsub/src/config.rs
@@ -750,7 +750,7 @@ impl GossipsubConfigBuilder {
     }
 
     /// Constructs a [`GossipsubConfig`] from the given configuration and validates the settings.
-    pub fn build(&self) -> Result<GossipsubConfig, &str> {
+    pub fn build(&self) -> Result<GossipsubConfig, &'static str> {
         // check all constraints on config
 
         if self.config.max_transmit_size < 100 {