Skip to content

Commit

Permalink
core/src/muxing: Remove deprecated function (#2665)
Browse files Browse the repository at this point in the history
  • Loading branch information
thomaseizinger authored May 23, 2022
1 parent ef2afcd commit 8361fab
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
2 changes: 2 additions & 0 deletions core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# 0.33.0 [unreleased]

- Have methods on `Transport` take `&mut self` instead of `self`. See [PR 2529].
- Remove deprecated function `StreamMuxer::is_remote_acknowledged`. See [PR 2665].

[PR 2529]: https://github.com/libp2p/rust-libp2p/pull/2529
[PR 2665]: https://github.com/libp2p/rust-libp2p/pull/2665

# 0.32.1

Expand Down
11 changes: 0 additions & 11 deletions core/src/muxing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,17 +203,6 @@ pub trait StreamMuxer {
/// Destroys a substream.
fn destroy_substream(&self, s: Self::Substream);

/// Returns `true` if the remote has shown any sign of activity after the muxer has been open.
///
/// For optimisation purposes, the connection handshake of libp2p can be very optimistic and is
/// allowed to assume that the handshake has succeeded when it didn't in fact succeed. This
/// method can be called in order to determine whether the remote has accepted our handshake or
/// has potentially not received it yet.
#[deprecated(note = "This method is unused and will be removed in the future")]
fn is_remote_acknowledged(&self) -> bool {
true
}

/// Closes this `StreamMuxer`.
///
/// After this has returned `Poll::Ready(Ok(()))`, the muxer has become useless. All
Expand Down

0 comments on commit 8361fab

Please sign in to comment.