-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kad: rename to follow naming convention across repository #4485
Comments
libp2p-kad
:
Hi @thomaseizinger ! I am interested to contribute this issue. Just one question. |
In general, yes! The goal we want to achieve is a balance between symbol length, expressiveness and ambiguity. The idea is that users can import the To start with, dropping the prefix from all symbols should be good enough. As a 2nd step, I'd recommend going over them and checking, that they still make sense. Depending on how thorough you want to be with that this might require diving into understanding what the protocol does (not sure if you are familiar with Kademlia at all?). Let us know what your appetite is for working on this and we can set the scope accordingly :) |
Note: We want this to be backwards compatible. I'd suggest reading some of the conversations in PRs linked in #2217. |
Renamed the following `kad::Kademlia` -> `kad::Behaviour` `kad::KademliaEvent` -> `kad::Event` `kad::KademliaBucketInserts` -> `kad::BucketInserts` `kad::KademliaStoreInserts` -> `kad::StoreInserts` `kad::KademliaConfig` -> `kad::Config` `kad::KademliaCaching` -> `kad::Caching` `kad::KademliaEvent` -> `kad::Event` `kad::KademliaConnectionType` -> `kad::ConnectionType` `KademliaHandler` -> `Handler` `KademliaHandlerEvent` -> `HandlerEvent` `KademliaProtocolConfig` -> `ProtocolConfig` `KademliaHandlerIn` -> `HandlerIn` `KademliaRequestId` -> `RequestId` `KademliaHandlerQueryErr` -> `HandlerQueryErr` Resolves: #4485 Pull-Request: #4547.
As tracked in #2217, we should rename the
Kademlia
behaviour toBehaviour
and all related symbols such that users can import it as:The text was updated successfully, but these errors were encountered: