Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: move {In,Out}boundUpgrade to libp2p-swarm #4697

Open
Tracked by #2863
thomaseizinger opened this issue Oct 20, 2023 · 1 comment
Open
Tracked by #2863

core: move {In,Out}boundUpgrade to libp2p-swarm #4697

thomaseizinger opened this issue Oct 20, 2023 · 1 comment
Assignees
@thomaseizinger

Comments

@thomaseizinger
Copy link
Contributor

Once we land #4695, we should be able to move the other traits to libp2p-swarm which means we can then specialize for example UpgradeInfo to use StreamProtocol directly and overall simplify the traits.
@thomaseizinger thomaseizinger mentioned this issue Oct 20, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger changed the title core: move {In,Out}boundUpgrade to `libp2p-swarm core: move {In,Out}boundUpgrade to libp2p-swarm Oct 24, 2023
@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Oct 24, 2023
@thomaseizinger thomaseizinger mentioned this issue Oct 26, 2023
Open
@thomaseizinger thomaseizinger self-assigned this Oct 26, 2023
@thomaseizinger thomaseizinger mentioned this issue Nov 2, 2023
Closed
4 tasks
@thomaseizinger thomaseizinger removed this from the v0.53.0 milestone Nov 2, 2023
@thomaseizinger
Copy link
Contributor Author

I think instead of moving these, it would actually be better to introduce new ones in libp2p-swarm and deprecate the others to enable a smooth transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaseizinger thomaseizinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move stream upgrades to libp2p-swarm libp2p/rust-libp2p
1 participant
@thomaseizinger