Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ConnectionHandler trait by removing as many associated types as possible #2863

Open
8 of 14 tasks
thomaseizinger opened this issue Sep 1, 2022 · 11 comments
Open
8 of 14 tasks

Simplify ConnectionHandler trait by removing as many associated types as possible #2863

thomaseizinger opened this issue Sep 1, 2022 · 11 comments
Labels
tracking-issue Issues which are the entry point to bigger projects.

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Sep 1, 2022 •
edited
Loading

Simplify the ConnectionHandler interface. This is one of the first interfaces users get in touch with when the implement their own protocols. Making it as simple as possible without removing functionality should be the goal. All but {To,From}Behaviour should be removed and we should directly hand the negotiated stream to the ConnectionHandler without any form of "upgrade".

Sub-epics
Beta Give feedback
  1. Simplified handling of idle connections #4306
    6 of 6
    tracking-issue
  2. swarm: Deprecate ConnectionHandler::{In,Out}boundOpenInfo #3268
    8 of 9
    difficulty:moderate help wanted priority:nicetohave
  4. swarm: Remove ConnectionHandler::Error #3591
    9 of 9
    difficulty:moderate help wanted priority:nicetohave

Use ReadyUpgrade everywhere
Beta Give feedback
  1. relay: refactor stream handling away from {In,Out}boundUpgrade #4075
    difficulty:moderate help wanted
    dgarus
  2. refactor(identify): use ReadyUpgrade for {In,Out}boundUpgrade #4563
    send-it
  3. refactor(request-response): don't use upgrade infrastructure #3914
    send-it
  4. refactor(kad): use ReadyUpgrade for {In,Out}boundUpgrade #4649
    difficulty:easy getting-started help wanted

Migration plan
Beta Give feedback
  1. core: introduce {In,Out}boundConnectionUpgrade traits #4307
    difficulty:easy help wanted
  2. Change all uses of {In,Out}boundUpgrade in transports to {In,Out}boundConnectionUpgrade #4521
    1 of 5
  3. core: move {In,Out}boundUpgrade to libp2p-swarm #4697
    thomaseizinger
  4. swarm: Remove {In,Out}boundUpgrade #4790
@thomaseizinger

This comment was marked as outdated.

Sign in to view
@thomaseizinger

This comment was marked as outdated.

Sign in to view
@thomaseizinger

This comment was marked as outdated.

Sign in to view
This was referenced Sep 2, 2022
Open
Merged
@mxinden

This comment was marked as outdated.

Sign in to view
@thomaseizinger thomaseizinger mentioned this issue Sep 8, 2022
Closed
8 tasks
@mxinden

This comment was marked as outdated.

Sign in to view
@thomaseizinger thomaseizinger mentioned this issue Sep 27, 2022
Closed
@thomaseizinger

This comment was marked as outdated.

Sign in to view
@mxinden

This comment was marked as outdated.

Sign in to view
@thomaseizinger

This comment was marked as outdated.

Sign in to view
This was referenced Dec 20, 2022
Open
Open
@thomaseizinger thomaseizinger mentioned this issue Jan 10, 2023
Closed
4 tasks
@thomaseizinger

This comment was marked as outdated.

Sign in to view
@thomaseizinger

This comment was marked as outdated.

Sign in to view
@mxinden

This comment was marked as outdated.

Sign in to view
@elenaf9 elenaf9 mentioned this issue Jan 30, 2023
Closed
@jxs jxs mentioned this issue Jan 31, 2023
Closed
4 tasks
@thomaseizinger thomaseizinger mentioned this issue Mar 29, 2023
Open
@thomaseizinger thomaseizinger mentioned this issue Apr 10, 2023
Closed
4 tasks
@thomaseizinger thomaseizinger mentioned this issue Apr 18, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue Apr 26, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger mentioned this issue May 11, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger mentioned this issue Jun 13, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue Jun 15, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue Aug 9, 2023
Closed
@thomaseizinger thomaseizinger modified the milestone: Simplify ConnectionHandler trait Sep 18, 2023
@thomaseizinger thomaseizinger mentioned this issue Sep 20, 2023
Closed
@thomaseizinger thomaseizinger added tracking-issue Issues which are the entry point to bigger projects. and removed difficulty:moderate help wanted labels Sep 20, 2023
@thomaseizinger thomaseizinger changed the title swarm/handler: Decouple ConnectionHandler from {In,Out}boundUpgrade Decouple ConnectionHandler from {In,Out}boundUpgrade Sep 20, 2023
@thomaseizinger thomaseizinger changed the title Decouple ConnectionHandler from {In,Out}boundUpgrade Simplify ConnectionHandler trait by removing as many associated types as possible Sep 20, 2023
This was referenced Sep 26, 2023
Closed
Merged
mergify bot pushed a commit that referenced this issue Sep 28, 2023
@dgarus
refactor(identify): use ReadyUpgrade for {In,Out}boundUpgrade
ecdd0ff 
Related: #2863.

Pull-Request: #4563.
mergify bot pushed a commit that referenced this issue Oct 26, 2023
@thomaseizinger @oblique
refactor(request-response): don't use upgrade infrastructure
fd7b5ac 
This patch refactors `libp2p-request-response` to not use the "upgrade infrastructure" provided by `libp2p-swarm`. Instead, we directly convert the negotiated streams into futures that read and write the messages.

Related: #3268.
Related: #2863.

Pull-Request: #3914.

Co-authored-by: Yiannis Marangos <yiannis@eiger.co>
This was referenced Nov 2, 2023
Closed
Draft
@thomaseizinger thomaseizinger mentioned this issue Dec 22, 2023
Closed
4 tasks
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this issue Mar 8, 2024
@thomaseizinger @oblique
refactor(request-response): don't use upgrade infrastructure
77a8818 
This patch refactors `libp2p-request-response` to not use the "upgrade infrastructure" provided by `libp2p-swarm`. Instead, we directly convert the negotiated streams into futures that read and write the messages.

Related: libp2p#3268.
Related: libp2p#2863.

Pull-Request: libp2p#3914.

Co-authored-by: Yiannis Marangos <yiannis@eiger.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tracking-issue Issues which are the entry point to bigger projects.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomaseizinger @mxinden