Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiaddr_to_socketaddr test failing on master #49

Closed
tomaka opened this issue Nov 28, 2017 · 1 comment
Closed

multiaddr_to_socketaddr test failing on master #49

tomaka opened this issue Nov 28, 2017 · 1 comment

Comments

@tomaka
Copy link
Member

tomaka commented Nov 28, 2017

https://github.com/paritytech/rust-libp2p/blob/710dec31108385e43e871aab50c385d1abdd0e24/libp2p-tcp-transport/src/lib.rs#L155-L161

This test has been there for a long time and it has suddenly started failing, probably after a cargo update.
@tomaka
Copy link
Member Author

tomaka commented Nov 30, 2017

Turns out this was caused by rust-lang/rust#46270.
Updating my Rust compiler also fixed the issue.

@tomaka tomaka closed this as completed Nov 30, 2017
mxinden pushed a commit to mxinden/rust-libp2p that referenced this issue Nov 20, 2020
@blacktemplar
Gossipsub v1.1 various improvements (libp2p#49)
5d93c0a 
* remove dbg! calls and add debug logging for peer scoring

* export MessageAcceptance and rename validate_message to report_message_validation_result to also signal that this message should get called in case of invalid messages

* fix double reject_message call

* gossip promises are fulfilled already on receiving the message without validation

* derive debug for MessageAcceptance

* add helper method to get config builder from existing config

* allow adding/changing TopicScoreParams during runtime

* more debug output for messages from self

* fixes incompatibility with anonymous PeerId in lighthouse

* cargo fmt

* more debug output for broken promises
dkuehr pushed a commit to openmina/rust-libp2p that referenced this issue Oct 24, 2023
@akoptelov
Use rust-format for generated files
0c67e01 
Re libp2p#49
dkuehr pushed a commit to openmina/rust-libp2p that referenced this issue Oct 24, 2023
@akoptelov
Use rust-format for generated files
7ffb055 
Re libp2p#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka