Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multistream-select to stable futures #1484

Merged
merged 4 commits into from
Mar 11, 2020

Conversation

tomaka
Copy link
Member

@tomaka tomaka commented Mar 5, 2020

Close #1331
This is a less sexy version of #1331, where we just do a one-to-one conversion to futures 0.3, without attempting to use async/await.

Using async/await at such a low level means that we have to box futures, which means that we have to enforce Send and 'static everywhere, which isn't great.

After this PR, futures 0.1 has disappeared from my Cargo.lock.

@tomaka tomaka requested review from twittner and romanb March 5, 2020 17:17
@tomaka
Copy link
Member Author

tomaka commented Mar 5, 2020

I'm currently building Polkadot with this PR (as a way to fuzz the code), and will report how it goes.
EDIT: seems to work totally fine

Copy link
Contributor

@twittner twittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka merged commit 31271fc into libp2p:master Mar 11, 2020
@tomaka tomaka deleted the mselect-stable-fut-2 branch March 11, 2020 14:08
romanb pushed a commit to romanb/rust-libp2p that referenced this pull request Oct 5, 2020
Fixes a panic when using the `V1Lazy` negotiation protocol,
a regression introduced in libp2p#1484.

Thereby adds integration tests for a transport upgrade with both
`V1` and `V1Lazy` to the `multistream-select` crate to prevent
future regressions.
romanb added a commit that referenced this pull request Oct 7, 2020
…nvenient transport boxing. (#1783)

* [multistream-select] Fix panic with V1Lazy and add integration tests.

Fixes a panic when using the `V1Lazy` negotiation protocol,
a regression introduced in #1484.

Thereby adds integration tests for a transport upgrade with both
`V1` and `V1Lazy` to the `multistream-select` crate to prevent
future regressions.

* Cleanup.

* Update changelog.
santos227 pushed a commit to santos227/rustlib that referenced this pull request Jun 20, 2022
…nvenient transport boxing. (#1783)

* [multistream-select] Fix panic with V1Lazy and add integration tests.

Fixes a panic when using the `V1Lazy` negotiation protocol,
a regression introduced in libp2p/rust-libp2p#1484.

Thereby adds integration tests for a transport upgrade with both
`V1` and `V1Lazy` to the `multistream-select` crate to prevent
future regressions.

* Cleanup.

* Update changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants