[libp2p-swarm] Correct returned connections from notify_all. #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If at least one connection was not ready (i.e. pending), only those (pending) connections would be returned and considered on the next iteration, whereas those which were ready should also remain in the list of connections to notify on retry of `notify_all`.
|
It occurred to me after a question from @twittner that it seems unnecessary to implement |
twittner
approved these changes
Mar 25, 2020
tomaka
approved these changes
Mar 25, 2020
folex
added a commit
to fluencelabs/rust-libp2p
that referenced
this pull request
Mar 30, 2020
…ibp2p#1513)" This reverts commit 28ea62d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a potential issue with
notify_allin the swarm discovered on another review of the code triggered by #1509: If at least one connection was not ready (i.e. pending), only those (i.e. the pending) connections would be returned and considered on the next task wakeup, whereas those which were ready should also remain in the list of connections to notify on task wakeup and retry ofnotify_all. I admit that this deserves better testing, as doeslibp2p-swarmin general, which I hope to spend some more time on soon.