Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export OneShotHandlerConfig. Make fields public. #1538

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Re-export OneShotHandlerConfig. Make fields public. #1538

merged 2 commits into from
Apr 1, 2020

Conversation

romanb
Copy link
Contributor

@romanb romanb commented Apr 1, 2020 •
edited
Loading

This is supposed to address the issues I ran into with the recent introduction of OneShotHandlerConfig: #1521 (comment).

@romanb romanb requested a review from tomaka April 1, 2020 14:21
tomaka
tomaka approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the overlook

@tomaka tomaka merged commit 6af530d into libp2p:master Apr 1, 2020
@romanb romanb deleted the fix-oneshot branch April 1, 2020 17:10
@sireliah
Copy link
Contributor

sireliah commented Apr 1, 2020

Thanks for finding this out @romanb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka tomaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanb @sireliah @tomaka