Temporarily bound all async-std dependencies. #1589
Conversation
|
Is the rustdoc-links check failure a nightly rust issue maybe? Any hints? |
| @@ -87,7 +87,7 @@ libp2p-tcp = { version = "0.19.0", path = "transports/tcp", optional = true } | |||
| libp2p-websocket = { version = "0.19.0", path = "transports/websocket", optional = true } | |||
|
|
|||
| [dev-dependencies] | |||
| async-std = "1.0" | |||
| async-std = "< 1.6" | |||
There was a problem hiding this comment.
Would this allow versions below 1.0 to be used? If so how about >=1.0, < 1.6.
There was a problem hiding this comment.
I can't find anything about that in the docs, but it might indeed be the case
There was a problem hiding this comment.
I don't think it really matters as cargo prefers newer versions, doesn't it? Do you think the lower bound is important?
There was a problem hiding this comment.
There's a general problem in the Rust ecosystem: you might be using features introduced in foo v1.1 but only have foo v1.0 in your dependencies. Cargo is theoretically allowed to depend on foo v1.0, which would make the compilation fail.
This issue is present a bit everywhere in the ecosystem, but people don't realize it because as you said Cargo prefers newer versions.
I'd say we're in the same situation here, so I'm tempted to not care.
There was a problem hiding this comment.
Mmh, due to semver libp2p selects a version smaller than 1.0, so 0.99 gets selected currently. I think the correct fix would be =1.5
There was a problem hiding this comment.
Yeah we've actually been bitten by it in Polkadot and released two versions with an old async-std (that had the bug with a high number of threads being spawned) without realizing.
This PR temporarily and conservatively bounds all
async-stddependencies in libp2p to< 1.6as at least the noise smoke tests seem to stall with1.6. This is just a temporary defensive measure to stabilise CI and avoid surprises in releases, until the underlying issue has been figured out and #1588 has been resolved.