Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: adapt distributed-key-value-store to also GET / PUT providers #1704

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

BlackYoup
Copy link
Contributor

This PR is related to #1526.

I adapted the distributed-key-value-store example to also support provide and get providers queries.

Let me know if you'd prefer this in a whole other example. I also didn't rename the example as I'm not sure how to call it.

Copy link
Contributor

@romanb romanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #1526 the example should also work for two nodes using provider records.

@romanb
Copy link
Contributor

romanb commented Aug 17, 2020

With #1526 the example should also work for two nodes using provider records.

By "should" I mean that I actually tried it, thanks for updating the example to make that easy!

@romanb romanb merged commit 269a2ac into libp2p:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants