Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mplex] Refactoring with Patches #1769

Merged
merged 17 commits into from
Sep 28, 2020
Merged

[mplex] Refactoring with Patches #1769

merged 17 commits into from
Sep 28, 2020

Commits on Sep 22, 2020

  1. Refactor Mplex. 

    Thereby addressing the following issues:

  * Send a `Reset` frame when open substreams get dropped (313).
  * Avoid stalls caused by a read operation on one substream
    reading (and buffering) frames for another substream without
    notifying the corresponding task. I.e. the tracked read-interest
    must be scoped to a substream.
  * Remove dropped substreams from the tracked set of open
    substreams, to avoid artificially running into substream
    limits.
    Roman S. Borschel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    b1fb745 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.

    Roman S. Borschel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    5d9c0e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Refine behaviour of dropping substreams. 

    By taking the substream state into account. The refined
behaviour is modeled after the behaviour of Yamux.
    Roman S. Borschel committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    82fb112 View commit details
    Browse the repository at this point in the history

  2. Tweak docs and recv buffer retention.

    Roman S. Borschel committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    9ff2e55 View commit details
    Browse the repository at this point in the history

  3. Further small tweaks. 

     * Make the pending frames a FIFO queue.
 * Take more care to avoid keeping read-wakers around
   and to notify them when streams close.
    Roman S. Borschel committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    0133dd1 View commit details
    Browse the repository at this point in the history

  4. Prefer wake over unregister. 

    It is probably safer to always wake pending wakers.
    Roman S. Borschel committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    6e6c637 View commit details
    Browse the repository at this point in the history

  5. Update muxers/mplex/src/codec.rs 

    Co-authored-by: Max Inden <mail@max-inden.de>
    @romanb @mxinden
    romanb and mxinden authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    154385f View commit details
    Browse the repository at this point in the history

  6. Update muxers/mplex/src/io.rs 

    Co-authored-by: Max Inden <mail@max-inden.de>
    @romanb @mxinden
    romanb and mxinden authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d15a5b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Some review feedback and cosmetics.

    Roman S. Borschel committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    dbe8337 View commit details
    Browse the repository at this point in the history

  2. Update muxers/mplex/src/io.rs 

    Co-authored-by: Max Inden <mail@max-inden.de>
    @romanb @mxinden
    romanb and mxinden authored Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7ed7e01 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Revise read control flow for clarity. 

    While seemingly duplicating some control flow between
`poll_next_strean` and `poll_read_stream`, the individual
control flow of each read operation is easier to follow.
    Roman S. Borschel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    7bd1498 View commit details
    Browse the repository at this point in the history

  2. CI

    Roman S. Borschel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    a050d11 View commit details
    Browse the repository at this point in the history

  3. Rename Status::Ok to Status::Open.

    Roman S. Borschel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    adca14f View commit details
    Browse the repository at this point in the history

  4. Rename pending_flush to pending_flush_open.

    Roman S. Borschel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    37c464c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Finishing touches.

    Roman S. Borschel committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    77ea68b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-mplex

    Roman S. Borschel committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    f17a861 View commit details
    Browse the repository at this point in the history

  3. Tweak changelog.

    Roman S. Borschel committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    436635e View commit details
    Browse the repository at this point in the history