[ping] Add missing flush after write. #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sending the ping and before awaiting the pong, the stream must be flushed to guarantee the data is sent before awaiting the reply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sending the ping and before awaiting the pong, the stream must be flushed to guarantee the data is sent before awaiting the reply. This is not necessary with
libp2p-yamuxwhere every sent frame is flushed, but with mplex it may remain sitting in a buffer otherwise. This problem was revealed by #1758 together with some other mplex issues addressed in #1769. This PR is on top of #1769 since the tests randomise usage of mplex and yamux and only pass consistently with these patches. For a proper diff (it is small), see here.Together with #1769, closes #1758.