Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: update tutorial with correct static methods in ping example #2035

Closed
wants to merge 1 commit into from
Closed

src: update tutorial with correct static methods in ping example #2035

wants to merge 1 commit into from

Conversation

therealdannzor
Copy link

Running the example in a separate project results in errors because of two missing method implementations. This small update makes the ping-pong example work 😄 .

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing out the tutorial @therealdannzor and also thanks for preparing a patch!

#1995 has been merged since the last release, allowing calling methods on a Swarm directly. Thus with the next release this will be fixed. I will prepare a release soon to make sure the confusion is removed.

If you link to the current master branch directly, things should compile fine.

See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories

@therealdannzor
Copy link
Author

Thanks for testing out the tutorial @therealdannzor and also thanks for preparing a patch!

#1995 has been merged since the last release, allowing calling methods on a Swarm directly. Thus with the next release this will be fixed. I will prepare a release soon to make sure the confusion is removed.

If you link to the current master branch directly, things should compile fine.

See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories

Thanks for letting me know and for the quick reply, I wasn't aware of this planned fix. I'll close this then :)

@therealdannzor therealdannzor deleted the tutorial-update-ping-pong branch April 7, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants