Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates #2228

Merged
merged 12 commits into from
Sep 25, 2021
Merged

CI updates #2228

merged 12 commits into from
Sep 25, 2021

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Sep 10, 2021

  • Swatinem/rust-cache handles Rust cache better

@kpp kpp mentioned this pull request Sep 11, 2021
@kpp
Copy link
Contributor

kpp commented Sep 14, 2021

Fixed in #2233

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but otherwise a welcoming change from my end. Personally I've had a good experience with rust-cache so far!

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

We will have to wait for @mxinden to merge this. He is currently on vacation though so that might take a little longer :)

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TriplEight. Very much appreciate your help here! Good to have a GitHub CI expert around.

@mxinden mxinden merged commit 6f7a19e into libp2p:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants