Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/gossipsub: Implement std::error::Error for error types #2254

Merged
merged 5 commits into from
Oct 1, 2021
Merged

protocols/gossipsub: Implement std::error::Error for error types #2254

merged 5 commits into from
Oct 1, 2021

Conversation

McFranko
Copy link
Contributor

It's annoying to work with these error types, because they can't be used with the ? operator. This fixes that

thomaseizinger
thomaseizinger requested changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add a changelog entry please?

protocols/gossipsub/src/error.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/error.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title Adding impls for std::error::Error on error types in gossipsub protocols/gossipsub: Implement std::error::Error for error types Sep 30, 2021
thomaseizinger
thomaseizinger approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mxinden
mxinden approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @McFranko

@mxinden mxinden merged commit decfead into libp2p:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McFranko @thomaseizinger @mxinden