Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm/src/behaviour: Fix outdated comment on derive's out_event #2318

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Oct 29, 2021

The default behaviour changed with
#2214. This updates the doc
comment.

Initially raised in
#2290 (comment).


While this fixes the actual mismatch, I think it is missing an example in order for newcomers to actually be able to understand the concepts.

//CC @kpp

The default behaviour changed with
libp2p#2214. This updates the doc
comment.

Initially raised in
libp2p#2290 (comment).
@mxinden
Copy link
Member Author

mxinden commented Oct 29, 2021

Sorry that I missed this as part of the PR. If none beats me to it, I'll send an update in the next couple of days!

No worries! Just to make sure there is no duplicate work, this PR does the fix @thomaseizinger.

@mxinden mxinden merged commit 997cc9a into libp2p:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants